[benchmarks] Fix edit and "after edit" experiments #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
force-pushed
the
fix-edit-experiments
branch
from
3e3b3db
to
5cd4c26
Compare
jneira
approved these changes
Aug 22, 2021
When the example includes >1 modules, we have to wait for the progress start of every edit. This is the sequence of events: --> didChange A.hs --> didChange B.hs <-- ProgressStart (for A.hs change) <-- ProgressDone (aborted) <-- ProgressStart (for B.hs change) <-- ProgressDone The experiment needs to ignore the aborted progress done events and wait until the last progress done event. To accomplish this, we wait for all the progress start events and then wait for one progress done event
pepeiborra
force-pushed
the
fix-edit-experiments
branch
from
5cd4c26
to
6e738f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the example includes >1 modules (like the Cabal example), this is the sequence of events:
The edit and "after edit" experiments usually want to wait until the final set of diagnostics is produced. Currently the edit experiment waits for one progress start and one progress done, while the "after edit" experiments wait for one progress done. This is only correct if there is only one module in the example. When there are two or more, as seen above, it's not enough. The experiment needs to ignore the aborted progress done events and wait until the last progress done event.
This PR makes changes to wait for one progress start event per module and then wait for one progress done event after changing the last module.