Skip to content

Set bounds for retrie by ghc #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

jneira
Copy link
Member

@jneira jneira commented Sep 8, 2021

@jneira jneira requested a review from pepeiborra September 8, 2021 21:03
@pepeiborra
Copy link
Collaborator

This shouldn't be necessary, ghcide doesn't care, it's the Cabal solver job to find a working set of versions right?

@jneira
Copy link
Member Author

jneira commented Sep 9, 2021

This shouldn't be necessary, ghcide doesn't care, it's the Cabal solver job to find a working set of versions right?

yep, but it is not able to do it in this case, will try increasing max-backjumps but the package should be built with the default one 😟

@pepeiborra
Copy link
Collaborator

pepeiborra commented Sep 9, 2021

This shouldn't be necessary, ghcide doesn't care, it's the Cabal solver job to find a working set of versions right?

yep, but it is not able to do it in this case, will try increasing max-backjumps but the package should be built with the default one 😟

It is able to do it in CI just fine except in the new workflow. Why?

@jneira
Copy link
Member Author

jneira commented Sep 9, 2021

It is able to do it in CI just fine except in the new workflow. Why?

I've tried to reproduce locally, following the workflow steps verbatim and i am not able to reproduce neither, even with a fresh new cabal config and cache. The main diff is i am on windows.

@jneira
Copy link
Member Author

jneira commented Sep 9, 2021

Aaaand https://github.com/haskell/haskell-language-server/actions/runs/1216111548 has built ghcide without the change of this pr but adding a upper bound to extras, wonderful

Will close eyes and the pr 😛

@jneira jneira closed this Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants