Fix hackage release #2177
Merged
Fix hackage release #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jneira
commented
Sep 9, 2021
•
jneira
commented
- run a cabal update
- show the entire diff if the package version is already released
- fix condition existence of a previous version released
pepeiborra
reviewed
Sep 10, 2021
.github/workflows/hackage.yml
Outdated
Comment on lines
87
to
88
| - name: "Ensure we will use hackage head" | ||
| run: cabal update |
There was a problem hiding this comment.
isn't this done in line 74 already? Why do it twice?
There was a problem hiding this comment.
oops bad merge, thanks for noting it
pepeiborra
approved these changes
Sep 10, 2021
|
this one has to be manually merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.