Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom version of operational #2249

Merged
merged 10 commits into from
Oct 5, 2021
Merged

Remove custom version of operational #2249

merged 10 commits into from
Oct 5, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Sep 30, 2021 •
edited by gitpod-io bot
Loading

@jneira jneira mentioned this pull request Sep 30, 2021
Closed
@jneira
Copy link
Member Author

jneira commented Sep 30, 2021

I've removed the source package from nix but it needs something to use operational released version (see fail here: https://github.com/haskell/haskell-language-server/runs/3752456136)
Any nix expert could propose or commit the proper fix? @berberman?

@jneira
Copy link
Member Author

jneira commented Sep 30, 2021

/rerun-workflow Testing

@michaelpj
Add Nix override for operational
c38d903 
Nixpkgs hasn't caught up with hackage yet.
@michaelpj
Copy link
Collaborator

Pushed a fix, I hope.

@michaelpj
Copy link
Collaborator

Now it's just some windows thing?

@jneira
Copy link
Member Author

jneira commented Oct 1, 2021 •
edited
Loading

Now it's just some windows thing?

Yeah the same thing in all prs since #2060 was merged (window tests were flaky before but they passed from time to time, now it is very improbable). I tried to fix it without luck in #2248 and pepe in #2243 😓

@jneira
Copy link
Member Author

jneira commented Oct 4, 2021

@michaelpj so this would be good to merge?

@michaelpj
Copy link
Collaborator

Oh yes certainly, I was just wondering what was up with the Windows stuff.

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Oct 4, 2021
@jneira
Copy link
Member Author

jneira commented Oct 4, 2021

Oh yes certainly, I was just wondering what was up with the Windows stuff.

the label still needs some approving review to be effective 🙂

@michaelpj
Copy link
Collaborator

Oh lol, I forgot we required approving reviews, sorry.

@jneira jneira mentioned this pull request Oct 4, 2021
Closed
35 tasks
@jneira jneira mentioned this pull request Oct 5, 2021
Closed
@mergify mergify bot merged commit f80f07a into master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jneira @michaelpj