Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore null WatchedFile events #2278

Merged
merged 2 commits into from
Oct 17, 2021
Merged

Ignore null WatchedFile events #2278

merged 2 commits into from
Oct 17, 2021

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Oct 17, 2021 •
edited
Loading

#2266 didn't succeed in preventing double rebuilds. Let's not restart the build when the list of changes is empty.

This is another spinoff from #2263

jneira
jneira approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for splitting the main pr and make it easy to reviee

@pepeiborra pepeiborra merged commit 768ae65 into master Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepeiborra @jneira