Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix excessive interface recompilation caused by the Tactics plugin #2282

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Oct 19, 2021

The Tactics HLS plugin installs a GHC plugin that forces the recompilation checker to bail out, since the plugin uses the default "RecompileAlways" strategy.

As found in #2151 this is very bad, causing .hi and .hie files to be regenerated unnecessarily, indexed, etc.

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Oct 19, 2021
Copy link
Collaborator

@isovector isovector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What a subtle bug! Thanks for the find and the fix!

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing catch, congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants