[skip circleci] Add option to effectively cancel prev runs #2310
Conversation
jneira
commented
Oct 29, 2021
•
jneira
commented
- Without using skip-duplicate-actions which is failing due to github access permission.
- See Warning: Failed to cancel https://github.com/pingcap/dm/actions/runs/766226952 fkirc/skip-duplicate-actions#103 and https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#concurrency
- We can keep skip-duplicate-actions, as it is cancelling and skipping using other criteria. But i suspect it can only cancel others if the branch source of the pr belongs to this repo
Without using skip-duplicate-actions which is failing due to github access permission. See fkirc/skip-duplicate-actions#103
jneira
changed the title
|
https://github.com/pingcap/dm/pull/1935/files this is our repo's modification, for your reference |
oh, i see, now it will cancel another workflows for the same branch, many many thanks |
Without it will cancel other workflows for the same branch Credits: 7b371e8b
jneira
changed the title
|
@lance6716 dont want to abuse, but i see the workflow you changed was skipping the job if the pr modified the README.md, did you replace that with another way to do it? |
currently we can't skip jobs for only modifying README.md 😂 that didn't happen too often. |
|
We are gonna [skip circleci] |
* Add option to cancel prev runs Without using skip-duplicate-actions which is failing due to github access permission. See fkirc/skip-duplicate-actions#103 * Cancel by branch *and* workflow Without it will cancel other workflows for the same branch Credits: 7b371e8b * Disable cancelling other runs Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
