Add README.md in install/ subproject #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
approved these changes
Nov 2, 2021
|
What change? 😅 |
jneira
reviewed
Nov 2, 2021
install/README.md
Outdated
| # hls-install | ||
|
|
||
| This directory contains the `hls-install` project, an Haskell Language Server installer. | ||
| It is used when [installing from sources](../docs/installation.md#building). |
There was a problem hiding this comment.
We are using absolute urls to readthedocs for links, see the main README as example
There was a problem hiding this comment.
Done (and I took the liberty to fix a few other links in the documentation)
There was a problem hiding this comment.
oh, but links inside docs themselves can be (and should be i suppose) relative, we need absolute ones in external resources like README's
There was a problem hiding this comment.
Oh I see, my bad 🤦 I have force-pushed the fix
There was a problem hiding this comment.
dont worry, looks perfect now, i could be more specific, will update to head to get the ci fix
|
[skip circleci]
sorry i was looking why ci failed 😅 |
sir4ur0n
force-pushed
the
sir4ur0n/doc/installDirectory
branch
from
348f8c1
to
9592921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2309