Trace diagnostics #2333
Merged
Trace diagnostics #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already disable this in ghcide tests It introduces noise (traces are harder to read), and can potentially break tests too (e.g. eval plugin)
|
could we keep some tests with the option enabled? it is the default for now and maybe would be good to keep it covered in some way |
There are tests that exercise this option in the ghcide test suite already. I'll have a look at the splice plugin test failures, maybe that test suite depends on this option being enabled for some reason |
pepeiborra
force-pushed
the
trace-diagnostics
branch
from
bae0528
to
6264f5a
Compare
|
@jneira this is ready to merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include rule diagnostics in traces for diagnosing diagnostic issues
Also disable checkProject in HLS test suite.
We already disable this in ghcide tests, since it introduces noise (traces are harder to read), and can potentially break tests too (e.g. eval plugin)