Skip to content

Bring in fix for libm on Linux static binaries #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

lukel97
Copy link
Collaborator

@lukel97 lukel97 commented Aug 6, 2020

Waiting to get some testing on the binaries produced at https://github.com/bubba/haskell-language-server/releases/tag/libmfix0 first

@lukel97 lukel97 marked this pull request as ready for review August 7, 2020 10:46
@lukel97
Copy link
Collaborator Author

lukel97 commented Aug 7, 2020

Seems to be fixing the libm errors in #221. Not exactly the nicest fix but buys us some time at least for now

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!
Hopefully, we find a proper fix soon

@lukel97 lukel97 merged commit cb430d3 into haskell:master Aug 7, 2020
pepeiborra added a commit that referenced this pull request Dec 27, 2020
* Document symbols provider

* Compatibility with GHC 8.4

* Replace large number with more descriptive maxBound

Co-Authored-By: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com>

* Use SkFunction for all Val Declarations

* Improve outlining of PatBind and FunBind

No longer relying on gfindtype

Co-authored-by: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants