Use an importance score to order the suggested import code action #3271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophHochrainer
force-pushed
the
feature/3234_order_import_suggestions
branch
2 times, most recently
from
7727c92 to
fc7d687
Compare
Collaborator
|
Hi! Please include a test, or an example how the behaviour is now improved! (I've seen how much it is improved, but we want to document it for everyone else as well) |
pepeiborra
reviewed
Oct 8, 2022
plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction.hs
Outdated
Show resolved
Hide resolved
plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction.hs
Outdated
Show resolved
Hide resolved
plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction.hs
Outdated
Show resolved
Hide resolved
ChristophHochrainer
force-pushed
the
feature/3234_order_import_suggestions
branch
2 times, most recently
from
e30fdb8 to
8aece66
Compare
ChristophHochrainer
force-pushed
the
feature/3234_order_import_suggestions
branch
from
8aece66 to
f6f1c83
Compare
michaelpj
reviewed
Oct 10, 2022
Collaborator
michaelpj
left a comment
michaelpj
left a comment
There was a problem hiding this comment.
Were we going to get some tests?
| data ImportSuggestion = ImportSuggestion !Int !CodeActionKind !NewImport | ||
| deriving ( Eq ) | ||
|
|
||
| instance Ord ImportSuggestion where |
Collaborator
There was a problem hiding this comment.
I think this Ord instance is not lawful because it doesn't compare the CodeActionKind, which is taken into account by the Eq instance.
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this! I will fix this ASAP
ChristophHochrainer
added a commit
to ChristophHochrainer/haskell-language-server
that referenced
this pull request
Oct 10, 2022
michaelpj
pushed a commit
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeAction,NewImport) into anImportSuggestionImportSuggestionfirst based on the score in descending order and second based on the import module names in alphabetic orderBefore the PR changes:
After the PR changes: