Skip to content

Remove Cabal dependency from hls-cabal-plugin #3383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions plugins/hls-cabal-plugin/hls-cabal-plugin.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -33,19 +33,7 @@ library
build-depends:
, base >=4.12 && <5
, bytestring
-- Ideally, we only want to support a single Cabal version, supporting
-- older versions is completely pointless since Cabal is backwards compatible,
-- the latest Cabal version can parse all versions of the Cabal file format.
--
-- However, stack is making this difficult, if we change the version of Cabal,
-- we essentially need to make sure all other packages in the snapshot have their
-- Cabal dependency version relaxed.
-- Most packages have a Hackage revision, but stack won't pick these up (for sensible reasons)
-- automatically, forcing us to manually update the packages revision id.
-- This is a lot of work for almost zero benefit, so we just allow more versions here
-- and we eventually completely drop support for building HLS with stack.
, Cabal ^>=3.2 || ^>=3.4 || ^>=3.6 || ^>= 3.8
, Cabal-syntax ^>= 3.6
, Cabal-syntax ^>= 3.8
, deepseq
, directory
, extra >=1.7.4
Expand Down
2 changes: 1 addition & 1 deletion stack-lts19.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ ghc-options:
"$everything": -haddock

extra-deps:
- Cabal-3.6.0.0
- Cabal-syntax-3.8.1.0
# needed for tests of hls-cabal-fmt-plugin
- cabal-fmt-0.1.6@sha256:54041d50c8148c32d1e0a67aef7edeebac50ae33571bef22312f6815908eac19,3626
- floskell-0.10.6@sha256:e77d194189e8540abe2ace2c7cb8efafc747ca35881a2fefcbd2d40a1292e036,3819
Expand Down
1 change: 1 addition & 0 deletions stack.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ extra-deps:
- lsp-types-1.6.0.0
- lsp-test-0.14.1.0
- hie-bios-0.11.0
- Cabal-syntax-3.8.1.0

# currently needed for ghcide>extra, etc.
allow-newer: true
Expand Down