Skip to content

Make the Ormolu plugin respect .ormolu fixity files when Ormolu ≥0.5.3.0 #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2023
Merged

Make the Ormolu plugin respect .ormolu fixity files when Ormolu ≥0.5.3.0 #3449

merged 1 commit into from
Feb 26, 2023

Conversation

amesgen
Copy link
Contributor

@amesgen amesgen commented Jan 9, 2023 •
edited
Loading

Closes #3448; includes a regression test

@amesgen amesgen requested a review from georgefst as a code owner January 9, 2023 18:42
@amesgen amesgen marked this pull request as draft January 9, 2023 18:42
@amesgen amesgen force-pushed the respect-ormolu-fixity-files branch 2 times, most recently from aaffad3 to 95c1654 Compare January 9, 2023 22:23
georgefst
georgefst approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@georgefst georgefst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

As for the reasons this is currently a draft, is there any particular conceptual reason why it would be difficult to better expose the functionality from upstream? Or is it just something that requires some boring grunt work?

@georgefst georgefst mentioned this pull request Jan 17, 2023
Open
@amesgen
Copy link
Contributor Author

amesgen commented Jan 17, 2023

As for the reasons this is currently a draft, is there any particular conceptual reason why it would be difficult to better expose the functionality from upstream? Or is it just something that requires some boring grunt work?

It is just an API design question, e.g. involving how "coarsely-grained" mirroring the behavior of the executable via the Haskell API should be (see tweag/ormolu#969 and in particular tweag/ormolu#970 (review)).

@amesgen amesgen force-pushed the respect-ormolu-fixity-files branch 4 times, most recently from 25800b6 to 32bbafe Compare January 21, 2023 15:33
@amesgen
Copy link
Contributor Author

amesgen commented Jan 21, 2023

Relevant upstream PR: tweag/ormolu#976

@amesgen amesgen force-pushed the respect-ormolu-fixity-files branch 3 times, most recently from 284838e to fe6f3f4 Compare January 25, 2023 18:57
@amesgen amesgen mentioned this pull request Jan 27, 2023
Closed
@amesgen amesgen force-pushed the respect-ormolu-fixity-files branch from fe6f3f4 to 0c958da Compare January 27, 2023 12:54
@amesgen amesgen changed the title Make the Ormolu plugin respect .ormolu fixity files Make the Ormolu plugin respect .ormolu fixity files when Ormolu ≥0.5.3.0 Jan 27, 2023
@amesgen amesgen marked this pull request as ready for review January 27, 2023 12:56
@amesgen amesgen force-pushed the respect-ormolu-fixity-files branch from 0c958da to 6ee636f Compare January 27, 2023 12:58
@amesgen amesgen force-pushed the respect-ormolu-fixity-files branch from 6ee636f to e9f9a49 Compare February 26, 2023 21:30
fendor
fendor requested changes Feb 26, 2023
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, awesome!
Just want to discuss the SomeException change, otherwise good to go!

@fendor fendor added the merge me Label to trigger pull request merge label Feb 26, 2023
@mergify mergify bot merged commit 4d5ce72 into haskell:master Feb 26, 2023
@amesgen amesgen deleted the respect-ormolu-fixity-files branch February 26, 2023 22:40
wz1000 pushed a commit that referenced this pull request Mar 14, 2023
@amesgen @wz1000
Make the Ormolu plugin respect .ormolu fixity files (#3449)
49d851a 
when Ormolu ≥0.5.3.0
@amesgen amesgen mentioned this pull request Jul 26, 2023
Closed
@georgefst georgefst mentioned this pull request Oct 24, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@georgefst georgefst georgefst approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.ormolu files are ignored when formatting with Ormolu
3 participants
@amesgen @fendor @georgefst