Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 2.0.0.1 release (for GHC 9.6.2 and 9.2.8) #3608

Closed
wants to merge 9 commits into from
Closed

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented May 27, 2023

Changelog 2.0.0.1


@michaelpj @fendor @wz1000 @mpickering


Release checklist

@hasufell
Copy link
Member Author

hasufell commented May 27, 2023

@hasufell
Copy link
Member Author

hasufell commented May 27, 2023

There's a problem with the release tar jobs running out of space... it seems we need to improve the space management somehow, otherwise we'll be constrained to 6 GHCs per tarball or so.

So I removed 9.6.1.

@wz1000
Copy link
Collaborator

wz1000 commented May 27, 2023

I don't think we need 9.2.7 either.

@hasufell
Copy link
Member Author

I don't think we need 9.2.7 either.

I think we do. It's the last 'recommended' release, which means lots of users will still be on it and have a saturated cabal cache.

But if dropping it makes CI pass, ok.

We might need some tweaks to the Makefile to delete GHC versions directly after they are used.

My laptop is in repair, so I can't continue.

@wz1000
Copy link
Collaborator

wz1000 commented May 29, 2023

I think we do. It's the last 'recommended' release, which means lots of users will still be on it and have a saturated cabal cache.

Those users can continue using 2.0.0.0

@hasufell
Copy link
Member Author

I think we do. It's the last 'recommended' release, which means lots of users will still be on it and have a saturated cabal cache.

Those users can continue using 2.0.0.0

That's not really good user experience. Only our vscode plugin is smart enough to downgrade automatically.

GHCup doesn't have a simple way to show a matrix. Most users will bump HLS to recommended/latest and still have projects using 9.2.7, because they don't want to rebuild all dependencies just yet.

@aryairani
Copy link

Out of disk space in CI

@hasufell
Copy link
Member Author

Space issues have been fixed: https://github.com/haskell/haskell-language-server/actions/runs/5370295916

I'll finalize the release shortly.

@hasufell
Copy link
Member Author

haskell/ghcup-metadata#96

Comment on lines +1 to +5
# Releasing

## Release checklist

- [ ] check ghcup supports new GHC releases if any
Copy link
Collaborator

@fendor fendor Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate this list a lot, but there seems to be a big overlap with https://github.com/haskell/haskell-language-server/blob/master/docs/contributing/releases.md

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChangeLog and version changes look good to me.

@hasufell
Copy link
Member Author

@hasufell hasufell closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin for record-selector to record dot syntax
4 participants