Skip to content

Keep plugin id of cabal-fmt in sync with default config id #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Keep plugin id of cabal-fmt in sync with default config id #3615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3c5d2b
Keep plugin id of cabal-fmt in sync with default config id
VeryMilkyJoe May 30, 2023
06c2bd6
Merge branch 'master' into fix-cabal-fmt
michaelpj Jun 2, 2023
1d84c07
Merge branch 'master' into fix-cabal-fmt
michaelpj Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hls-plugin-api/src/Ide/Types.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ instance Default Config where
-- , formattingProvider = "floskell"
-- , formattingProvider = "stylish-haskell"
, cabalFormattingProvider = "cabal-fmt"
-- this string value needs to kept in sync with the value provided in HlsPlugins
, maxCompletions = 40
, plugins = mempty
}
Expand Down
4 changes: 3 additions & 1 deletion src/HlsPlugins.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,9 @@ idePlugins recorder = pluginDescToIdePlugins allPlugins
let pId = "fourmolu" in Fourmolu.descriptor (pluginRecorder pId) pId:
#endif
#if hls_cabalfmt
let pId = "cabalfmt" in CabalFmt.descriptor (pluginRecorder pId) pId:
-- this pId needs to be kept in sync with the hardcoded
-- cabalFormattingProvider in the Default Config
let pId = "cabal-fmt" in CabalFmt.descriptor (pluginRecorder pId) pId:
#endif
#if hls_tactic
let pId = "tactics" in Tactic.descriptor (pluginRecorder pId) pId:
Expand Down