Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump actions/checkout from 3 to 4" #3813

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Revert "Bump actions/checkout from 3 to 4" #3813

merged 2 commits into from
Sep 20, 2023

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Sep 19, 2023

This caused release CI to fail, see https://github.com/haskell/haskell-language-server/actions/runs/6230276461

actions/checkout@v4 uses node 20 which requires GLIBC that is too new for our distributions

fendor
fendor approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I think only release.yaml strictly requires the downgrade

@wz1000 wz1000 added the merge me Label to trigger pull request merge label Sep 20, 2023
@mergify mergify bot merged commit a734e1a into master Sep 20, 2023
37 of 41 checks passed
@fendor fendor mentioned this pull request Sep 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@Anton-Latukha Anton-Latukha Awaiting requested review from Anton-Latukha

@Ailrun Ailrun Awaiting requested review from Ailrun

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wz1000 @fendor