Drop support for GHC 9.0 #3875
Merged
Drop support for GHC 9.0 #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
requested review from
Anton-Latukha,
Ailrun,
konn,
pepeiborra,
santiweight,
OliverMadine,
berberman,
eddiemundo,
July541 and
fendor
as code owners
wz1000
reviewed
Nov 16, 2023
| @@ -1219,12 +1215,7 @@ uses_th_qq (ms_hspp_opts -> dflags) = | |||
| -- Depends on whether it uses unboxed tuples or sums | |||
| computeLinkableTypeForDynFlags :: DynFlags -> LinkableType | |||
| computeLinkableTypeForDynFlags d | |||
| #if defined(GHC_PATCHED_UNBOXED_BYTECODE) || MIN_VERSION_ghc(9,2,0) | |||
There was a problem hiding this comment.
Remove this flag from the cabal file?
fendor
approved these changes
Nov 16, 2023
Comment on lines
662
to
664
| tcSplitForAllTyVars :: Type -> ([TyVar], Type) | ||
| tcSplitForAllTyVars = | ||
| #if MIN_VERSION_ghc(9,2,0) | ||
| TcType.tcSplitForAllTyVars |
There was a problem hiding this comment.
Should we perhaps delete this simple function definition?
Its initial purpose is gone.
This raises the question again, whether we can carve out an GHC API out of our usage...
There was a problem hiding this comment.
Yes, I didn't go through doing simplification, which I should...
michaelpj
force-pushed
the
mpj/drop-ghc-9
branch
from
66eba02
to
afe6f09
Compare
|
Okay, tests hopefully fixed and I did a bit of simplification in ghcide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3872.
I removed the macros automatically, so let's see if this builds!