Exactprint plugins for 9.8 #3973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz1000
requested review from
michaelpj,
konn,
pepeiborra,
santiweight and
July541
as code owners
jhrcek
reviewed
Jan 17, 2024
michaelpj
reviewed
Jan 17, 2024
| @@ -703,7 +703,11 @@ typeWildCardActionTests = testGroup "type wildcard actions" | |||
| [ "func :: _" | |||
| , "func x y = x + y" | |||
| ] | |||
| #if MIN_VERSION_ghc(9,7,0) | |||
| [ "func :: a -> a -> a" -- 9.8 has a different suggestion | |||
There was a problem hiding this comment.
this seems kind of bad, is this an upstream regression?
wz1000
force-pushed
the
wip/exactprint-9.8
branch
from
cf59f50
to
6f60029
Compare
|
I have no idea what the failing test is testing for or why it is desirable. It seems require that we don't suggest adding a import Data.List.NonEmpty ()
f = nonEmpty |
|
I see, it wants us to not suggest adding a new import, instead we should suggest extending the existing import. All the tests have been fixed locally now. |
michaelpj
reviewed
Jan 18, 2024
|
Great, thanks for tracking that down! |
michaelpj
approved these changes
Jan 18, 2024
konn
approved these changes
Jan 18, 2024
wz1000
force-pushed
the
wip/exactprint-9.8
branch
from
4daa5ff
to
3c89823
Compare
|
Yeah, it seems like we can use |
|
Still a build failure in the gadt tests |
…gin (#3979) * Fix -Wall and -Wunused-packages in call-hierarchy plugin * Make tests more uniform
wz1000
force-pushed
the
wip/exactprint-9.8
branch
from
6cd05e3
to
c728986
Compare
josephsumabat
pushed a commit
to josephsumabat/haskell-language-server
that referenced
this pull request
Jan 22, 2024
* Exactprint plugins for 9.8 * Fix last test * comments * fix borked cpp * Don't use CPP in refactor plugin tests * Fix -Wall, -Wunused-packages and hlint warnings in call-hierarchy plugin (haskell#3979) * Fix -Wall and -Wunused-packages in call-hierarchy plugin * Make tests more uniform * accept func test differences * Run tests for 9.8 plugins in CI * Fix another test --------- Co-authored-by: Jan Hrcek <2716069+jhrcek@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran out of steam fixing this refactor plugin test:
Perhaps someone else would like to have a look?