Fix -Wall and -Wunused-packages in pragmas plugin #3982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
commented
Jan 18, 2024
| @@ -176,8 +170,8 @@ mkEdit :: (UInt,UInt) -> (UInt,UInt) -> T.Text -> TextEdit | |||
| mkEdit (startLine, startCol) (endLine, endCol) newText = | |||
| TextEdit (Range (Position startLine startCol) (Position endLine endCol)) newText | |||
|
|
|||
| completionTest :: String -> FilePath -> T.Text -> T.Text -> Maybe InsertTextFormat -> Maybe T.Text -> Maybe T.Text -> [UInt] -> TestTree | |||
| completionTest testComment fileName replacementText expectedLabel expectedFormat expectedInsertText detail [delFromLine, delFromCol, delToLine, delToCol, completeAtLine, completeAtCol] = | |||
| completionTest :: String -> FilePath -> T.Text -> T.Text -> Maybe InsertTextFormat -> Maybe T.Text -> Maybe T.Text -> (UInt, UInt, UInt, UInt, UInt, UInt) -> TestTree | |||
There was a problem hiding this comment.
I find it less evil to use 6-tuple than to disable incomplete-patterns warning just to be able to pass fixed length list 😏
jhrcek
commented
Jan 18, 2024
| , completionTest "completes language extensions case insensitive" "Completion.hs" "lAnGuaGe Overloaded" "OverloadedStrings" Nothing Nothing Nothing [0, 4, 0, 34, 0, 24] | ||
| , completionTest "completes the Strict language extension" "Completion.hs" "Str" "Strict" Nothing Nothing Nothing [0, 13, 0, 31, 0, 16] | ||
| , completionTest "completes No- language extensions" "Completion.hs" "NoOverload" "NoOverloadedStrings" Nothing Nothing Nothing [0, 13, 0, 31, 0, 23] | ||
| , onlyWorkForGhcVersions (>=GHC92) "GHC2021 flag introduced since ghc9.2" $ |
There was a problem hiding this comment.
2 changes here:
- changing lists of integers to 6-tuples
- removing conditional which is no longer needed now that ghcs < 9.2 are not supported
|
Sorry, mistakenly closes this PR when cleaning up branches in my fork.. reopening. |
michaelpj
approved these changes
Jan 19, 2024
josephsumabat
pushed a commit
to josephsumabat/haskell-language-server
that referenced
this pull request
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.