Fix -Wall and -Wunused-packages in stan plugin #4014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
commented
Jan 24, 2024
jhrcek
commented
Jan 24, 2024
|
Sounds like there are some genuine questions, perhaps @0rphee can advise. |
|
Everything seems fine. Some errors seem to have eluded me! |
jhrcek
force-pushed
the
jhrcek/unused-packages-stan
branch
from
41b4ce0
to
f594d5e
Compare
|
@0rphee thanks for checking. @michaelpj This PR should be merge-ready. |
0rphee
approved these changes
Jan 26, 2024
jhrcek
force-pushed
the
jhrcek/unused-packages-stan
branch
from
24d3ff1
to
9a526a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of larger effort where I try to reduce the amount of compiler warnings across all packages.