Reduce the number of ad-hoc helper test functions in refactor plugin tests #4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
commented
Jan 30, 2024
| @@ -9,7 +9,6 @@ | |||
| {-# LANGUAGE PolyKinds #-} | |||
| {-# LANGUAGE RecordWildCards #-} | |||
| {-# LANGUAGE TypeOperators #-} | |||
| {-# OPTIONS_GHC -Wno-unticked-promoted-constructors #-} | |||
There was a problem hiding this comment.
This option is no turned on by default via common warnings import in haskell-language-server.cabal.
|
Huh, almost no tests were executed 🤔 is this something that's going to be resolved in #4024? |
fendor
approved these changes
Jan 30, 2024
It's a huge mess. Tidying that up would be a great blessing! |
jhrcek
force-pushed
the
jhrcek/refactor-plugin-unify-tests
branch
from
cc04024
to
2b4074e
Compare
jhrcek
force-pushed
the
jhrcek/refactor-plugin-unify-tests
branch
from
f5374b9
to
f26d13a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add couple of reproducers for refactor plugin issues that annoy me in my daily work.
But the existing tests trigger my OCD.
It seems that everyone who added tests came up with their own set of helper functions and shortcuts 😄
This PR shouldn't change the coverage, but it partially reduces the chaos by making the tests reuse smaller number of simple test helper functions.
More improvements could be done, but perfect is the enemy of good..