Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ghcide-test-utils as a separate package #4032

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

michaelpj
Copy link
Collaborator

Even stack now supports public sub-library dependencies, let's have one fewer weird package.

@michaelpj
Copy link
Collaborator Author

You know what, I'm going to do hls-test-utils too while I'm at it.

@michaelpj
Copy link
Collaborator Author

Oh, it looks like there hasn't actually been a release of stack with the new feature. Boo.

@michaelpj michaelpj marked this pull request as draft February 1, 2024 18:12
@michaelpj
Copy link
Collaborator Author

Looks like it's coming, but let's park this until then: commercialhaskell/stack#6397

@michaelpj
Copy link
Collaborator Author

Okay, ready to review. I didn't do hls-test-utils as @fendor thought it was a good idea to keep it separate so ghcide can potentially depend on it.

@michaelpj michaelpj marked this pull request as ready for review February 25, 2024 15:41
Copy link
Collaborator

@soulomoon soulomoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelpj michaelpj merged commit 949f3b8 into master Feb 26, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants