Improve hls class plugin test #4059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulomoon
force-pushed
the
improve-hls-class-plugin-test
branch
from
94cf26e to
5bee014
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
soulomoon
force-pushed
the
improve-hls-class-plugin-test
branch
from
708de54 to
5bee014
Compare
michaelpj
reviewed
Feb 8, 2024
| , testCase "Do not construct error action!, Ticket3942one" $ do | ||
| runSessionWithServer def classPlugin testDataDir $ do | ||
| doc <- openDoc "Ticket3942one.hs" "haskell" | ||
| _ <- waitForDiagnosticsFromSource doc (T.unpack sourceTypecheck) |
There was a problem hiding this comment.
This function is rather weird. I don't know why it isn't just a slight variant of waitForDiagnostics that adds an extra predicate...
michaelpj
reviewed
Feb 8, 2024
This one has a timeout, and something I am not so sure about. It seems some test rely on the timeout. |
|
Okay, well maybe let's at least note it down as something to investigate in #3736 |
michaelpj
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need to pass in the source to match the result, since its result is throwed away.
switching from
waitForDiagnosticsFromSourcetowaitForDiagnosticsFromimprove the test speed by magnitude.before
All 29 tests passed (88.71s)after
All 29 tests passed (5.74s)