stack CI: switch to offic. haskell images, bump to lts-22.9 (ghc 9.6.4) #4060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
commented
Feb 8, 2024
| @@ -20,25 +20,12 @@ extra-deps: | |||
| - retrie-1.2.2 | |||
| - hiedb-0.5.0.1 | |||
| - implicit-hie-0.1.4.0 | |||
| - hie-bios-0.13.1 | |||
There was a problem hiding this comment.
Removing these from extra-deps, because all of these are in lts-22.9
jhrcek
force-pushed
the
jhrcek/stack
branch
2 times, most recently
from
7c9b7cc to
07d4ef5
Compare
jhrcek
commented
Feb 8, 2024
| @@ -76,19 +60,22 @@ defaults: &defaults | |||
| version: 2 | |||
| jobs: | |||
| stackage-lts21: | |||
| docker: | |||
There was a problem hiding this comment.
Switching to official haskell images.
They already have latest stack installed and setup + specific version of ghc (corresponding to image tag) preinstalled. That means no need to have separate stack upgrade and stack setup steps.
Also ghc is installed in separate location, which means smaller CI caches since we're caching ~/.stack folder (so cache is about 1GB smaller because we don't have to cache GHC installation within ~/.stack)
jhrcek
changed the title
jhrcek
changed the title
michaelpj
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
this week I saw several instances of stack CI jobs failing with errors ala "failed to download stack binaries from fpcomplete servers".
I propose we switch to official haskell images which have latest stack preinstalled so we can avoid this class of failures altogether.