refactor plugin: fix regex for extracting import suggestions #4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
approved these changes
Feb 16, 2024
|
Ok, I'll come up with a test for this over the weekend. |
jhrcek
force-pushed
the
jhrcek/refactor-plugin-fix-regex-extracting-import-suggestions
branch
from
1098b0d
to
2cbeef1
Compare
fendor
reviewed
Feb 16, 2024
jhrcek
deleted the
jhrcek/refactor-plugin-fix-regex-extracting-import-suggestions
branch
soulomoon
pushed a commit
to soulomoon/haskell-language-server
that referenced
this pull request
Feb 22, 2024
soulomoon
pushed a commit
to soulomoon/haskell-language-server
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4079
The problem was that the original regex was mistakenly using
.as a regex metacharacter, whereas the GHC error contains a literal.In cases where GHC error contains further
)'s this led to 3rd match group (which is used to extract srcspan) to contain too much stuff, leading to errors described in the issue.If the tests pass, would you still recommend adding a test case for this or is it ok like this?