Fix resultBuilt(dirty mechanism) in hls-graph

hls-graph/src/Development/IDE/Graph/Internal/Database.hs

@@ -133,6 +133,9 @@ builder db@Database{..} stack keys = withRunInIO $ \(RunInIO run) -> do
  waitAll
  pure results
 
+
+-- | isDirty
+-- only dirty when it's build time is older than the changed time of one of its dependencies
 isDirty :: Foldable t => Result -> t (a, Result) -> Bool
 isDirty me = any (\(_,dep) -> resultBuilt me < resultChanged dep)
 
@@ -179,14 +182,23 @@ compute db@Database{..} stack key mode result = do
  deps <- newIORef UnknownDeps
  (execution, RunResult{..}) <-
  duration $ runReaderT (fromAction act) $ SAction db deps stack
- built <- readTVarIO databaseStep
+ curStep <- readTVarIO databaseStep
  deps <- readIORef deps
- let changed = if runChanged == ChangedRecomputeDiff then built else maybe built resultChanged result
- built' = if runChanged /= ChangedNothing then built else changed
- -- only update the deps when the rule ran with changes
+ let lastChanged = maybe curStep resultChanged result
+ let lastBuild = maybe curStep resultBuilt result
+ -- changed time would be slower
+ -- build time would be faster
+ let (changed, built) = case runChanged of
+ -- some thing changed
+ ChangedRecomputeDiff -> (curStep, curStep)
+ -- recomputed is the same
+ ChangedRecomputeSame -> (lastChanged, curStep)
+ -- nothing changed
+ ChangedNothing -> (lastChanged, lastBuild)
+ let -- only update the deps when the rule ran with changes
  actualDeps = if runChanged /= ChangedNothing then deps else previousDeps
  previousDeps= maybe UnknownDeps resultDeps result
- let res = Result runValue built' changed built actualDeps execution runStore
+ let res = Result runValue built changed curStep actualDeps execution runStore
  case getResultDepsDefault mempty actualDeps of
  deps | not (nullKeySet deps)
  && runChanged /= ChangedNothing

hls-graph/src/Development/IDE/Graph/Internal/Types.hs

@@ -187,7 +187,6 @@ instance NFData RunMode where rnf x = x `seq` ()
 -- | How the output of a rule has changed.
 data RunChanged
  = ChangedNothing -- ^ Nothing has changed.
- | ChangedStore -- ^ The stored value has changed, but in a way that should be considered identical (used rarely).
  | ChangedRecomputeSame -- ^ I recomputed the value and it was the same.
  | ChangedRecomputeDiff -- ^ I recomputed the value and it was different.
  deriving (Eq,Show,Generic)