Cleanup imports after CPP removal + few hlint fixes #4337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
commented
Jun 26, 2024
| @@ -116,13 +119,6 @@ import qualified System.Random as Random | |||
| import System.Random (RandomGen) | |||
| import Text.ParserCombinators.ReadP (readP_to_S) | |||
|
|
|||
|
|
|||
| -- See Note [Guidelines For Using CPP In GHCIDE Import Statements] | |||
There was a problem hiding this comment.
removing 9.2 compat code removed a lot of import CPP, making many of these comments irrelevant.
jhrcek
requested review from
konn,
soulomoon,
santiweight,
fendor and
wz1000
as code owners
|
One unavoidable stylish-haskell parsing failure in pre-commit job, otherwise it's ready to merge. |
dsaenztagarro
added a commit
to dsaenztagarro/haskell-language-server
that referenced
this pull request
Jun 30, 2024
* master: Formalize the ProgressReporting Type (haskell#4335) fix future index time (haskell#4343) Cleanup disabled warnings (haskell#4341) Cleanup imports after CPP removal + few hlint fixes (haskell#4337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.