Restrict editor config to Haskell file, to avoid affecting Makefiles or other tab-based formats

[tittoassini]

indent_style = space
makes it impossible to write Makefiles

[ndmitchell]

Thanks for the PR, seems like you had some problem editing Makefiles?

Doesn't this only impact files in the haskell-language-server directory? And we don't have any Makefiles that I can see. Did I miss some?

Plus, why restrict to hs/lhs and also add an explicit entry for Makefile? Shouldn't that just be left blank to leave editor defaults to trigger?

[tittoassini]

Hi Neil, the project doesn't have any makefile, but I do :-) and possibly others have so .. better not mess things up. I wasted a fair bit of time before realising why I could not edit correctly my Makefile anymore. As per the explicit entry for Makefile, you are correct, it is unnecessary but it makes double sure that Makefile editing uses tabs as it should. It could be taken out, but it doesn't hurt. Best Il giorno mar 29 set 2020 alle ore 12:58 Neil Mitchell < notifications@github.com> ha scritto:

…

Thanks for the PR, seems like you had some problem editing Makefiles? Doesn't this only impact files in the haskell-language-server directory? And we don't have any Makefiles that I can see. Did I miss some? Plus, why restrict to hs/lhs and also add an explicit entry for Makefile? Shouldn't that just be left blank to leave editor defaults to trigger? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#442 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFRQOMQ5JLAIMHIJMYGP3SIG4T7ANCNFSM4R5UCGRQ> .

-- Pasqualino "Titto" Assini http://networkpolitics.svbtle.com http://quid2.org/

[ndmitchell]

My understanding is that this .editorconfig should only apply to directories beneath it. So if you have a git checkout of haskell-language-server, only that directory should be impacted. Which editor are you using? Are the Makefile's under that directory for some reason?

[Ailrun]

That's my understanding too. Maybe there are some editor plugins using .editorconfig in a specific directory for every files outside of the dir (even though it sounds a bit weird), but I think those are issues of the plugins..

[tittoassini]

I have a Makefile in the haskell-language-server directory, that I use to implement a few basic tasks such as recompiling / testing / generating docs, etc. I think that it is rather common to have a little Makefile to keep track of these minor tasks. To edit it, I use the same editor I use for the code, i.e. VSCode, and the previous settings, that applied space tabbing to any file (not just haskell files) made it impossible for me to edit my Makefile. Let's do like this, drop the line relative to Makefile but keep the new settings that apply space tabbing only to haskell files, without affecting any other format that people might want to use for whatever reason. Deal? Il giorno mer 30 set 2020 alle ore 16:30 Junyoung Clare Jang < notifications@github.com> ha scritto:

…

That's my understanding too. Maybe there are some editor plugins using .editorconfig in a specific directory for every files outside of the dir (even though it sounds a bit weird), but I think those are issues of the plugins.. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#442 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFRQINDBPU2DYNQGJ7HWTSIM6IHANCNFSM4R5UCGRQ> .

-- Pasqualino "Titto" Assini http://networkpolitics.svbtle.com http://quid2.org/

[ndmitchell]

@tittoassini that makes sense now. Agreed that restricting the format changes to .hs/.lhs makes a lot of sense.

I wonder if the Makefile you have is useful enough that others might want to use it? Or is it specific to your approaches in a way that wouldn't be generally useful?

[tittoassini]

My Makefile is a mess, it would be like sharing my handkerchief, better avoid it :-) Il giorno mer 30 set 2020 alle ore 17:20 Neil Mitchell < notifications@github.com> ha scritto:

…

@tittoassini <https://github.com/tittoassini> that makes sense now. Agreed that restricting the format changes to .hs/.lhs makes a lot of sense. I wonder if the Makefile you have is useful enough that others might want to use it? Or is it specific to your approaches in a way that wouldn't be generally useful? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#442 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFRQNPVGXP4MKA4GBOZ6DSINECRANCNFSM4R5UCGRQ> .

-- Pasqualino "Titto" Assini http://networkpolitics.svbtle.com http://quid2.org/

[ndmitchell]

Thanks!

[jneira]

thank you!

[tittoassini]

thank you both :-)