Set the XDG_CACHE_HOME for tests #4572
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
fix/tests-xdg-cache-home
branch
from
1a34302 to
7df2e36
Compare
soulomoon
reviewed
Apr 27, 2025
|
Outdated skip in CI. Gonna fix that! |
michaelpj
approved these changes
Apr 27, 2025
|
Test failures all look genuine, so more investigation is required. |
fendor
force-pushed
the
fix/tests-xdg-cache-home
branch
from
3be9351 to
8dcd861
Compare
fendor
commented
May 7, 2025
| then mkHomeModLocation dflags (pathToModuleName fp) fp | ||
| then mkHomeModLocation dflags mod fp |
There was a problem hiding this comment.
This seems to be causing long-path issues on windows.
I am unsure how relevant this still is... Anybody an idea?
fendor
commented
May 7, 2025
| reexported = Position 55 14 ; reexportedSig = getDocUri "Bar.hs" >>= \bar -> return [ExpectHoverText ["Bar", "Bar", "Haddock"], if ghcVersion >= GHC94 && ghcVersion < GHC910 then mkL bar 3 5 3 8 else mkL bar 3 0 3 14] | ||
| reexported = Position 55 14 ; reexportedSig = getDocUri "Bar.hs" >>= \bar -> return [ExpectHoverText ["Bar", "Bar", "Haddock"], mkL bar 3 0 3 14] |
There was a problem hiding this comment.
This seems to be caused by a race/inconsistency between serving a hover request based on hiedb and getting the information from an interface file.
jian-lin
reviewed
May 7, 2025
fendor
force-pushed
the
fix/tests-xdg-cache-home
branch
2 times, most recently
from
019575a to
6920cae
Compare
This makes sure each test run is independent. Makes the tests * iface-error-test-1 * iface-th-test less flaky locally. Should not have any effect on the CI flakiness issue. --- Fix test cases to work with the temporary `XDG_CACHE_HOME` Some tests were launching additional HLS instances for the tests. Fixed, which should make the test slightly faster.
Ghcide test infrastructure was refactored to depend on `hls-test-utils`.
fendor
force-pushed
the
fix/tests-xdg-cache-home
branch
from
6920cae to
2a07a93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure each test run is independent.
Makes the tests
less flaky locally. On my machine, these tests were consistently failing after the first successful execution (due to caching the
hiedbafaict.)Should not have any effect on the CI flakiness issue.