Skip to content

Add doc for project-wide renaming #4584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

jian-lin
Copy link
Contributor

@jian-lin jian-lin commented May 6, 2025

Also add doc for sessionLoading since it is needed by project-wide renaming.

Doc for cabalFormattingProvider is also added. It is not tightly connected to the theme of this PR though.

related: #2193 #3738
closes: #4355

@jian-lin jian-lin requested a review from michaelpj as a code owner May 6, 2025 19:47
@jian-lin
Copy link
Contributor Author

jian-lin commented May 6, 2025

ping @fendor

@dschrempf
Copy link
Contributor

Not directly related, but is there a reason why mutipleComponents is not the default? It's cumbersome to define this for every project, isn't it? And it is annoying when you can not jump to a definition in another package of the same project. What are your experiences?

@jian-lin
Copy link
Contributor Author

jian-lin commented May 7, 2025

Maybe because:

Not sure if these reasons are outdated though.

Also note that mutipleComponents alone is not enough for project-wide renaming.

@fendor
Copy link
Collaborator

fendor commented May 7, 2025

is there a reason why mutipleComponents is not the default?

It can be slow without eager component loading, see #4381.
A regression as well: #4431
Also, we have no good way to let the user decide to use eager loading, except a custom hie.yaml.
Once these three issues are solved, I think it should be made the default!

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of the documentation!

@fendor
Copy link
Collaborator

fendor commented May 7, 2025

This PR also closes #4355

@jian-lin jian-lin force-pushed the pr/project-wide-rename-doc branch from 1e0ce20 to 0dca2a7 Compare May 7, 2025 07:27
@fendor fendor merged commit c3acee2 into haskell:master May 7, 2025
19 of 21 checks passed
@jian-lin jian-lin deleted the pr/project-wide-rename-doc branch May 7, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Components option is not documented in the online manual
3 participants