Skip to content

Add "autogen-" field completions and tests for cabal files #4587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented May 10, 2025

Adds completions 'autogen-incudes' and 'autogen-modules'.

Supersedes both #4534 and #4535

@fendor
Copy link
Collaborator Author

fendor commented May 10, 2025

cc @Sid1005 and @rm41339, I would appreciate your thumbs up and thanks for both of your contributions!

I took the best of both PRs, and added some comments for the future.

Copy link
Collaborator

@VeryMilkyJoe VeryMilkyJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one nitpick, but I don't mind if you prefer your version :)

Adds completions 'autogen-incudes' and 'autogen-modules'.

Co-authored-by: rm41339 <rachelma41339@gmail.com>
Co-authored-by: Siddharth_Ceri10 <89704257+Sid1005@users.noreply.github.com>
@fendor fendor force-pushed the enhance/cabal-plugin-autogen-completion branch from a01a9b6 to fe606f8 Compare May 11, 2025 15:15
@Sid1005
Copy link
Contributor

Sid1005 commented May 12, 2025

I enjoyed contributing to the haskell-language-server! Thank you.

@fendor fendor merged commit e00b5dd into haskell:master May 12, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants