Fix extend imports regression #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndmitchell
approved these changes
Jan 2, 2021
| @@ -628,7 +628,14 @@ suggestExtendImport exportsMap contents Diagnostic{_range=_range,..} | |||
| | Just match <- Map.lookup binding (getExportsMap exportsMap) | |||
| , [(ident, _)] <- filter (\(_,m) -> mod == m) (Set.toList match) | |||
| = Just ident | |||
| | otherwise = Nothing | |||
|
|
|||
| -- fallback to using GHC suggestion even though it is not always correct | |||
There was a problem hiding this comment.
I didn't see a test for this branch added - would be good to see it reflected there.
There was a problem hiding this comment.
Well, I duplicated the test suite to run without checkProject, but I just checked and it doesn't cover this branch. It might be very tricky to construct a test that covers it though, so I'm inclined to leave it until a user complains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression on the extend imports code action w.r.t 0.5.0.
It only arises when
checkProjectis disabled (by default it is enabled), so I extended the test suite to cover that case too