Skip to content

Regression quasi-quotes are not highlighted anymore #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrkkrp opened this issue Dec 29, 2015 · 6 comments
Closed

Regression quasi-quotes are not highlighted anymore #1041

mrkkrp opened this issue Dec 29, 2015 · 6 comments

Comments

@mrkkrp
Copy link
Contributor

mrkkrp commented Dec 29, 2015

That's it. Previously text beween [foo| and |] was highlighted just like string, but now it's not. In some cases highlighting “breaks” entirely at this point and the rest of document after quasi-quote is not highlighted at all. This regression is relatively new, I think it's less than a week old.

@gracjan
Copy link
Contributor

gracjan commented Dec 29, 2015 via email

@mrkkrp
Copy link
Contributor Author

mrkkrp commented Dec 30, 2015

Sure. Here is some nonsense that demonstrates the problem:

module Main where

main :: IO ()
main = setMsg MsgSuccess [shamlet|
this text is not highlighted
|]

@gracjan
Copy link
Contributor

gracjan commented Dec 30, 2015

Try to use some HTML inside the quasiquote:

main = setMsg MsgSuccess [shamlet|this text is <bold>bold</bold> and <italic>italic</italic>|]

@gracjan
Copy link
Contributor

gracjan commented Dec 30, 2015

But I agree font locking could be more pronouced here.

@mrkkrp
Copy link
Contributor Author

mrkkrp commented Dec 30, 2015

Why HTML inside should change anything? I do have a tag (without closing one, because it's Hamlet template) inside in my real code, but it's not highlighted there as well. Simpliest case would be to highlight everywhing between the pipes. Previously it worked (I think).

@gracjan
Copy link
Contributor

gracjan commented Jan 4, 2016

Now it should be more visible and should not break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants