haskell-mode-stylish-buffer is called in haskell-mode-after-save-handler

[gracjan]

Why AFTER save? Why not BEFORE?

Also haskell-mode-after-save-handler is pretty creepy as it conflicts with any other after save hook functions.

[bergey]

Ick. That is bizarre. a37fa71 seems to be the relevant commit, but it doesn't explain why. That predates b5e8f40, which makes haskell-mode-stylish-buffer use a temporary file. I think I understand why if the sequence was

• save
• stylish-haskell
• revert-buffer

That would make more sense in the after-save-hook.

Anyhow, I think it would make sense to:

• stop suppressing the save hooks
• remove basic-save-buffer
• move haskell-mode-stylish-buffer to before-save-handler

And test as best we can.

[gracjan]

@bergey: Good investigation! I think we should strive to get this code into expected shape, so into before save hook.

[gracjan]

Fixing this one will also fix #256 and #788.

[gracjan]

@bergey: Can you take this on you?

[gracjan]

ping?

[bergey]

@gracjan Can you reopen this per discussion in #1137

[wraithm]

This issue can be closed.