Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-process-path-* now allowed to be lists #1112

Closed
mikesperber opened this issue Jan 26, 2016 · 4 comments
Closed

haskell-process-path-* now allowed to be lists #1112

mikesperber opened this issue Jan 26, 2016 · 4 comments

Comments

@mikesperber
Copy link
Contributor

The customize specs for haskell-process-path-ghci & friends say they can be lists of strings. But the code actually only works with strings.

(I want to use ("nix-shell" "--run" "ghci").)
@gracjan
Copy link
Contributor

gracjan commented Jan 26, 2016

Thanks for the report. This should not be hard to fix. Can you help?

@mikesperber
Copy link
Contributor Author

I'd be happy to - I assume you mean actually handling lists, right? (Rather than outlawing them at the defcustom.)

@gracjan
Copy link
Contributor

gracjan commented Jan 26, 2016 via email

mikesperber added a commit to mikesperber/haskell-mode that referenced this issue Jan 28, 2016
@mikesperber
Allow haskell-process-path-* to be lists.
0207377 
Fixes haskell#1112.
@mikesperber mikesperber mentioned this issue Jan 28, 2016
Merged
@gracjan
Copy link
Contributor

gracjan commented Feb 4, 2016

Hi @mikesperber, I noticed that docstrings for haskell-process-path-ghci and friend are confusing now. Can you help and write better description?

(While you are at it a section about those does not exist in doc/haskell-mode.texi. Can you add it there?)

mikesperber added a commit to mikesperber/haskell-mode that referenced this issue Feb 5, 2016
@mikesperber
Docstrings and documentation for haskell-process-path-*.
16962c7 
(In the wake of haskell#1112.)
@mikesperber mikesperber mentioned this issue Feb 5, 2016
Merged
mikesperber added a commit to mikesperber/haskell-mode that referenced this issue Feb 6, 2016
@mikesperber
Docstrings and documentation for haskell-process-path-*.
208be76 
(In the wake of haskell#1112.)
mikesperber added a commit to mikesperber/haskell-mode that referenced this issue Feb 6, 2016
@mikesperber
Docstrings and documentation for haskell-process-path-*.
b0a0c55 
(In the wake of haskell#1112.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gracjan @mikesperber