haskell-yas causes issues when loading other modes

[diogo149]

When opening a file that loads a mode which requires yasnippet, yasnippet just breaks because an invalid path is added to yas-snippet-dirs (eg. if the file name is /some/path/foo.clj, /some/path/snippets is added), and this is caused by haskell-yas. When loading yasnippet, haskell-yas is loaded as well, and (buffer-file-name) is called with the current file, thus leading to the wrong relative path being loaded. This only occurs when yasnippet is loaded lazily.

My understanding is that switching the order of (buffer-file-name) and load-file-name in haskell-snippets-dir should fix the issue. I could submit a pull request if that's the right thing to do and you wouldn't rather do it yourself.

[purcell]

Right, I think I've fixed this now, by not using buffer-file-name at all: let me know if not!

[diogo149]

It indeed does work, thanks! I assumed that buffer-file-name was used for development though (re-evaluating the file).

[purcell]

I assumed that buffer-file-name was used for development though (re-evaluating the file).

Yes, but better to simply avoid it, I think, unless a developer complains. :-)