Skip to content

Declarations scanning gets stalled #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
k0ral opened this issue Apr 18, 2015 · 2 comments
Closed

Declarations scanning gets stalled #585

k0ral opened this issue Apr 18, 2015 · 2 comments

Comments

@k0ral
Copy link

k0ral commented Apr 18, 2015

The issue was noticed under OS-X and linux, at least.
When opening a haskell file, emacs freezes on the Scanning declarations in file.hs phase.
Reverting PR #580 fixes the issue.

Thank you !
@deviant-logic
Copy link
Contributor

If I read the docs right, looking-at-p differs from looking-at in that it doesn't mutate the match data. Presumably, some of the uses of looking-at in the declaration scanning code actually depended on the side-effect?

@gracjan
Copy link
Contributor

gracjan commented Apr 18, 2015

I've reverted in e5afe82. Still, there must be some twisted logic going on if that commit broke scanning.

@gracjan gracjan closed this as completed Apr 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deviant-logic @k0ral @gracjan