Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require at least Emacs 24.1 #1055

Merged
merged 2 commits into from
Jan 22, 2016
Merged

Require at least Emacs 24.1 #1055

merged 2 commits into from
Jan 22, 2016

Conversation

gracjan
Copy link
Contributor

@gracjan gracjan commented Jan 6, 2016

Fixes #847.

Note that we will merge this one after nearest melpa stable release.

@gracjan gracjan mentioned this pull request Jan 9, 2016
gracjan added a commit that referenced this pull request Jan 22, 2016
@gracjan gracjan merged commit ffeab32 into haskell:master Jan 22, 2016
@fice-t
Copy link
Contributor

fice-t commented Feb 6, 2016

@gracjan I thought about this when I saw a lot of set (make-local-variable 'x) instead of setq-local. I don't think 24.1 and 24.2 include cl-lib by default, so shouldn't support now only go back to 24.3?

@gracjan
Copy link
Contributor Author

gracjan commented Feb 6, 2016

I have neither 24.1 nor 24.2 handy (and we do not automatically test with those), but as I understand 24.1 has package manager and can install from Melpa. Our package explicitly depends on cl-lib so package manager should download cl-lib as a dependency for haskell-mode.

@gracjan
Copy link
Contributor Author

gracjan commented Feb 6, 2016

I just checked and 24.1.1 and 24.2.1 pass the test suite.

@fice-t
Copy link
Contributor

fice-t commented Feb 6, 2016

Ah, that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants