Define haskell-package struct's slots #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haskell-package's slots were not defined, and that was creating a byte-compiler warning that the lexical variable `pkg' was unused.
|
Your change makes sense to me. I think you are right about the struct. I suspect the whole module is unfinished, meant to be used for something unwritten. I'm not sure, though. |
gracjan
added a commit
that referenced
this pull request
Jan 15, 2016
Define haskell-package struct's slots
|
There is also haskell-cabal.el that is also unfinished.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haskell-package's slots were not defined, and that was creating abyte-compiler warning that the lexical variable
pkgwas unused.I made this commit just to shut up the byte-compiler (honestly, I just started using this mode).
As an aside, am I missing something, or is the struct not actually used? The
haskell-package-get*functions usehaskell-package-parseto create the struct, but nothing seems to actually use the result (I'm not sure how something could without the slots defined).