Skip to content

Utils coverage #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 16, 2016
Merged

Utils coverage #1089

merged 4 commits into from
Jan 16, 2016

Conversation

geraldus
Copy link
Contributor

Don't merge yet!

@gracjan I have no strong opinion on type-at-command-composition test. It looks very silly and feels like testing function's logic reimplementation. Maybe there are some other aspects we'd better to test?

I will add few other tests in few days.

Also, maybe it's better to move prettification stuff, e.g. comments, indentation, to another PR?

@@ -1,102 +1,179 @@
;;; haskell-utils-tests.el --- Tests for Haskell utilities package

;; Copyright © 2016 Athur Fayzrakhmanov. All rights reserved.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't treat this as self-praise or etc. this is GPL requirement. Also everyone who contribute to haskell-mode files should list themselves as authors.

@geraldus
Copy link
Contributor Author

I will add tests for haskell-utils-parse-repl-response and haskell-utils-reduce-string, but we still have no decision about async-stuff and hooks.
Ok, likely flags stuff could be easily tested. Will add new tests as separate PRs.

gracjan added a commit that referenced this pull request Jan 16, 2016
@gracjan gracjan merged commit d8c7c24 into haskell:master Jan 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants