Follow comma style when arranging a Cabal section #1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses haskell#1094: when calling `haskell-cabal-subsection-arrange-lines` on a Cabal section, only separate the lines in the section by commas when the section was already comma-separated. Ignore commas in strings or comments.
|
@mrBliss 👍 |
|
🍻 |
gracjan
added a commit
that referenced
this pull request
Jan 21, 2016
Follow comma style when arranging a Cabal section
mrBliss
added a commit
to mrBliss/haskell-mode
that referenced
this pull request
Jan 21, 2016
Previously, `haskell-cabal-list-comma-position` was always used when calling `haskell-cabal-subsection-arrange-lines`. In haskell#1098, `haskell-cabal-list-comma-position` was respected unless the no commas were found. Instead of respecting `haskell-cabal-list-comma-position`, detect the currently used style and respect it when rearranging the section. Possible styles: `before`: a comma at the start of each line (except the first), e.g. ```haskell Foo , Bar ``` `after`: a comma at the end of each line (except the last), e.g. ```haskell Foo, Bar ``` `single`: everything on a single line, but comma-separated, e.g. ```haskell Foo, Bar ``` `nil`: no commas, e.g. ```haskell Foo Bar ``` If the styles are mixed, the position of the first comma determines the style.
mrBliss
added a commit
to mrBliss/haskell-mode
that referenced
this pull request
Jan 21, 2016
Previously, `haskell-cabal-list-comma-position' was always used when calling `haskell-cabal-subsection-arrange-lines'. In haskell#1098, `haskell-cabal-list-comma-position' was respected unless the no commas were found. Instead of respecting `haskell-cabal-list-comma-position', detect the currently used style and respect it when rearranging the section. Possible styles: before: a comma at the start of each line (except the first), e.g. Foo , Bar after: a comma at the end of each line (except the last), e.g. Foo, Bar single: everything on a single line, but comma-separated, e.g. Foo, Bar nil: no commas, e.g. Foo Bar If the styles are mixed, the position of the first comma determines the style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1094: when calling
haskell-cabal-subsection-arrange-lineson a Cabal section, only separate the lines in the section by commas
when the section was already comma-separated. Ignore commas in strings
or comments.