Prevent haskell-doc-mode to hang Emacs during user input waiting #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (find-file file) | ||
| (cl-return)))) | ||
| do | ||
| (haskell-mode-set-interactive-prompt-state) |
There was a problem hiding this comment.
This has to be wrapped in elisp version of bracket that is unwind-protect.
There was a problem hiding this comment.
Oh, great! Likely I should use unwind-protect everywhere, shouldn't I?
|
Well, |
|
I wish I had some wrapper around unwind protect haskell-mode-set-interactive-prompt at the beginning of this PR :D Please review, I also want to add few simple tests before merge. |
|
If this will pass Travis I'm done. |
gracjan
added a commit
that referenced
this pull request
Jan 30, 2016
Prevent haskell-doc-mode to hang Emacs during user input waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #820.