Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few doc improvements and a bit of refactoring #1205

Merged
merged 4 commits into from
Mar 13, 2016
Merged

Few doc improvements and a bit of refactoring #1205

merged 4 commits into from
Mar 13, 2016

Commits on Mar 13, 2016

  1. Add some missing docstrings

    @geraldus
    geraldus committed Mar 13, 2016
    Configuration menu
    Copy the full SHA
    58642af View commit details
    Browse the repository at this point in the history

  2. A bit of refactoring

    @geraldus
    geraldus committed Mar 13, 2016
    Configuration menu
    Copy the full SHA
    6613021 View commit details
    Browse the repository at this point in the history

  3. Rename some functions 

    1. Renamed `haskell-cabal-get-setting` to `haskell-cabal--get-field`.
Word "field" was chosen because this word is used in cabal's user guide.
Double dash was used because this function is likely designed for
internal usage according to its logics, e.g. it do makes no checks and
just blindly searches for `:NAME` occurance in current buffer

2. `haskell-cabal-guess-setting` was renamed to
`haskell-cabal-get-field` because it does not guesses anything, but
simply tries to find cabal file and if succeeds calling
`haskell-cabal--get-field`.
    @geraldus
    geraldus committed Mar 13, 2016
    Configuration menu
    Copy the full SHA
    bd17a16 View commit details
    Browse the repository at this point in the history

  4. Fix warning

    @geraldus
    geraldus committed Mar 13, 2016
    Configuration menu
    Copy the full SHA
    2c68a36 View commit details
    Browse the repository at this point in the history