Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle operators in haskell-ident-pos-at-point too #1224

Merged
merged 5 commits into from
Mar 27, 2016
Merged

Handle operators in haskell-ident-pos-at-point too #1224

merged 5 commits into from
Mar 27, 2016

Conversation

geraldus
Copy link
Contributor

Let's see will it pass the tests. I think I can add some tests for operators too.

@geraldus
Copy link
Contributor Author

And it turns that we can drop haskell-completions-general-prefix due to prefix grabber no longer handles comments and strings (this will be next PR).

@geraldus
Copy link
Contributor Author

Don't merge this yet, this implementation is buggy :(

@gracjan
Copy link
Contributor

gracjan commented Mar 20, 2016

I think this function should be compatible with thing-at-point. That one seems to be standard.

@geraldus
Copy link
Contributor Author

@gracjan I agree, but not this time, ok? (:

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 30.248% when pulling 93e0111 on geraldus:g/fix-1213 into cc22219 on haskell:master.

@geraldus
Copy link
Contributor Author

@gracjan please review.

@gracjan
Copy link
Contributor

gracjan commented Mar 21, 2016

Looks good to me. Lets wait the usual two days so that other people may look at the code.

@geraldus geraldus mentioned this pull request Mar 21, 2016
@geraldus
Copy link
Contributor Author

@gracjan no one going to test this 😌

@gracjan gracjan merged commit 3b8c603 into haskell:master Mar 27, 2016
@gracjan
Copy link
Contributor

gracjan commented Mar 27, 2016

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants