Implement electric characters #1302
Conversation
fice-t
force-pushed
the
indentation
branch
2 times, most recently
from
6b3bd31 to
47b681a
Compare
| ind) | ||
| (self-insert-command arg) | ||
| (when (and at-indent? | ||
| haskell-indentation-electric-flag |
There was a problem hiding this comment.
Change this to:
(or (equal 'always haskell-indentation-electric-flag)
(bound-and-true-p 'electric-indent-mode))Then the mode changing hook will not be necessary.
There was a problem hiding this comment.
Thanks, I don't know why I didn't think of that. At that point haskell-indentation-electric-flag might as well just be used as a boolean, so I changed it accordingly.
fice-t
force-pushed
the
indentation
branch
2 times, most recently
from
efd33e8 to
7566120
Compare
| is non-nil. | ||
| 4) The point is not in a comment, string, or quasiquote." | ||
| (interactive "*p") | ||
| (let* ((col (haskell-indentation-current-indentation)) |
There was a problem hiding this comment.
Also: please check the (or haskell-indentation-electric-flag electric-indent-mode) in the beginning of the function. The point is that haskell-indentation-current-indentation may possibly be buggy, take lots of time or error-out. Therefore it should be invoked only after flag is enabled.
| @@ -87,18 +100,13 @@ | |||
| It rebinds RET, DEL and BACKSPACE, so that indentations can be | |||
| set and deleted as if they were real tabs." | |||
| :keymap haskell-indentation-mode-map | |||
| (kill-local-variable 'indent-line-function) | |||
There was a problem hiding this comment.
This kill-local-variables should stay here. Reason: minor modes may be switched on and off, this code path is for switching off (although it is executed always).
There was a problem hiding this comment.
Right, I was thinking that someone would always want either haskell-indent or haskell-indentation. I guess someone might want neither.
This defines various keys that will trigger auto reindentation when appropriate. This approach is somewhat similar to how `cc-mode' implements electric keys. Closes haskell#1133.
|
Code looks good, I plan to run it locally for a couple of days to see how it 'feels'. |
|
We should have a nice documentation page in manual. @fice-t, can you write it in |
|
Should that do for documentation? |
This does it like in `cc-mode'.
Also, I removed a few unnecessary things in the minor mode definition and removed an unused variable (Fixes #1294).
Closes #1133