Skip to content

Enable adaptive-fill-mode #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2016
Merged

Conversation

rasendubi
Copy link
Contributor

It was disabled in 96c8bbf because
haskell-adaptive-fill didn't work well. However, the default adaptive
fill rulles play nicely with Haskell, so it's pretty useful to keep it
enabled even without a custom adaptive-fill-function.

It was disabled in 96c8bbf because
`haskell-adaptive-fill` didn't work well. However, the default adaptive
fill rulles play nicely with Haskell, so it's pretty useful to keep it
enabled even without a custom adaptive-fill-function.
@gracjan
Copy link
Contributor

gracjan commented May 8, 2016

Can you check what is happening with the tests?

@rasendubi
Copy link
Contributor Author

Can't say these are real failures. I'd better change tests.

fill-comment-2:

{- a b c d e f g h i j k -}

now fills as

{- a b c d e
 f g h i j
 k -}

instead of

{- a b c d e
f g h i j
k -}

fill-comment-5:

    {-
 a b c d e f g h i
    -}

refills as

    {-
 a b c d e
 f g h i
    -}

instead of

    {-
 a b c d e
f g h i
    -}

This also fixes fill-comment-11 and fill-comment-12:

  --  a
  -- b c d e f g h i j

refills as

  --  a b
  -- c d e
  -- f g h
  -- i j

and

  --  a
  -- b c d e
--f g h
        --            i j

refills as

  --  a b
  -- c d e
  -- f g h
  -- i j

@gracjan
Copy link
Contributor

gracjan commented May 8, 2016

Good, please change tests, this works much better now.

@rasendubi
Copy link
Contributor Author

Done.

@gracjan gracjan merged commit 108acd1 into haskell:master May 8, 2016
@gracjan
Copy link
Contributor

gracjan commented May 8, 2016

Thanks.

rasendubi added a commit to rasendubi/dotfiles that referenced this pull request May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants