Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original shnippet in place of haskell-yas. #435

Closed
wants to merge 1 commit into from
Closed

Use original shnippet in place of haskell-yas. #435

wants to merge 1 commit into from

Conversation

gracjan
Copy link
Contributor

@gracjan gracjan commented Jan 18, 2015

Fixes #361.

Original 'shippet' is well maintained at https://github.com/LukeHoersten/shnippet. Someday it should be added as a git submodule. For now users are advised to refer to the original version directly.

Note that haskell-yas was a simple rename of shnippet and does not offer any additional functionality.

@purcell
Copy link
Member

purcell commented Jan 18, 2015

Have changes been made to the snippets following the import and renaming? shnippet hasn't been touched for a year.

I like the idea of keeping this out of haskell-mode, but until shnippet can be installed via package.el, I'd be wary of removing haskell-yas from the tree.

@purcell
Copy link
Member

purcell commented Jan 18, 2015

It's not completely unheard of for major modes to bundle yasnippets, even without declaring a package dependency on yasnippet, though, so if the other maintainers would prefer to keep this here then I don't feel strongly either way.

@gracjan
Copy link
Contributor Author

gracjan commented Jan 18, 2015

Imported snippets have not been changed since import. There also have been zero issue reports about snippets. Both strongly suggest that users do not care about shnippets inside haskell-mode.

Packaging shnippet properly is a very good idea that should be brought up in original repo: https://github.com/LukeHoersten/shnippet.

Original 'shippet' is well maintained at
https://github.com/LukeHoersten/shnippet. Someday it should be added as
a git submodule. For now users are advised to refer to the original
version directly.

Note that haskell-yas was a simple rename of shnippet and does not offer
any additional functionality.
@gracjan
Copy link
Contributor Author

gracjan commented Feb 17, 2015

As per #305 haskell-mode snippets are activelly maintained here: https://github.com/AndreaCrotti/yasnippet-snippets, haskell snippets are in subdirectory:

https://github.com/AndreaCrotti/yasnippet-snippets/tree/master/haskell-mode

Last change was done 20 days ago there, that indicates active comunity involvement.

@purcell
Copy link
Member

purcell commented Feb 19, 2015

That looks like a user fork with personal snippets. Not sure if it's usable. Best option is still to either keep the status quo, or package shnippet then merge this PR.

@gracjan gracjan closed this Mar 15, 2015
@lukehoersten
Copy link
Member

I still actively maintain shnippet - I'm not sure about AndreaCrotti fork since I've received no PRs. We should still come up with a better way to package shnippets into haskell-mode. I like the subrepo idea.

@lukehoersten lukehoersten reopened this Apr 22, 2015
@lukehoersten
Copy link
Member

Oops ment to open the issue not the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

haskell-yas.el should be a separate package
3 participants