Skip to content

Conversation

gracjan
Copy link
Contributor

@gracjan gracjan commented Mar 13, 2015

No description provided.

@gracjan
Copy link
Contributor Author

gracjan commented Mar 13, 2015

@purcell: I would appreciate a review and a merge.

@purcell
Copy link
Member

purcell commented Mar 13, 2015

You should probably explicitly set the coding for the file now that it contains the unicode chars.

I noticed the old code used char-displayable-p -- what case did that cover, and is it not needed any more?

@gracjan
Copy link
Contributor Author

gracjan commented Mar 13, 2015

char-displayable-p seems to come from times when Emacs wasn't Unicode and font handling was subpar. Now it seems that it can display all glyphs in all practical situations.

@gracjan
Copy link
Contributor Author

gracjan commented Mar 13, 2015

This file used to contain Unicode chars before my change. Still setting encoding explicitly seems like a good idea.

purcell added a commit that referenced this pull request Mar 13, 2015
…ymbols

Modernize haskell-font-lock-symbols.
@purcell purcell merged commit 14307cc into haskell:master Mar 13, 2015
@purcell
Copy link
Member

purcell commented Mar 13, 2015

Done in e191f50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants