Skip to content

Fix Emacs-snapshot build #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2015
Merged

Fix Emacs-snapshot build #600

merged 1 commit into from
Apr 24, 2015

Conversation

geraldus
Copy link
Contributor

Currently Emacs-snapshot Travis-CI build fails with following error:

In toplevel form:
haskell.el:90:63:Error: looking-back called with 1 argument, but requires 2-3
make: *** [haskell.elc] Error 1

According to documentaion of looking-back function in recent version
of Emacs, second and third arguments are optional. Second argument is
LIMIT, here is what documented:

LIMIT if non-nil speeds up the search by specifying a minimum
starting position, to avoid checking matches that would start
before LIMIT.

Thus, it turns that we can safely provide nil as LIMIT, which will not
affect current bahavoiur, but will fix error message.

Updated as suggested by @gracjan.

@gracjan
Copy link
Contributor

gracjan commented Apr 24, 2015

@geraldus: Use (line-beginning-position). There is a reason they require that LIMIT argument and beginning of line is the correct thing in this case.

Currently **Emacs-snapshot** Travis-CI build fails with following error:

> In toplevel form:
> haskell.el:90:63:Error: looking-back called with 1 argument, but requires 2-3
> make: *** [haskell.elc] Error 1

We need set LIMIT to `(line-beginning-position)` here.
gracjan added a commit that referenced this pull request Apr 24, 2015
@gracjan gracjan merged commit 4892713 into haskell:master Apr 24, 2015
@geraldus geraldus deleted the snapshot-build-fix branch April 25, 2015 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants