Tidy up haskell-present and haskell-process-do-simple-echo according to #607
#613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gracjan updated according to last comments and fixed Emacs 23 build failure |
Simplify `haskell-present`: + do not apply text properties to hint and fontification to buffer, because presentaions are fontified according to haskell mode automatically + properly assing presentation buffer to haskell session + make buffer readonly Rename `haskell-process-do-simple-echo` to `haskell-process-show-repl-response` and remove redundant mode argument Update doc strings
gracjan
added a commit
that referenced
this pull request
Apr 29, 2015
Tidy up `haskell-present` and `haskell-process-do-simple-echo` according to #607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
haskell-present:because presentaions are fontified according to haskell mode
automatically
Rename
haskell-process-do-simple-echotohaskell-process-show-repl-responseand remove redundant mode argumentUpdate doc strings